alway logout when is someone logged in #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to authentication flow handling and error resilience in serial port operations. The most important changes are:
Authentication flow improvements:
IdentityComponentsEndpointRouteBuilderExtensions.csto clarify the order of operations when handling external authentication logins. The user is now only signed in after ensuring the current user is logged out, and the code path for handling already-logged-in users with matching external authentication IDs is simplified.Serial port error handling:
OpenPortAsyncmethod inSerialService.csto gracefully catch and ignore exceptions thrown during the attempt to open a serial port, improving robustness against runtime errors.